SPDD validation test #261
Merged
SPDD validation test #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
lowhung
approved these changes
Oct 20, 2025
golddydev
approved these changes
Oct 21, 2025
Signed-off-by: William Hankins <william@sundae.fi>
…accurate SPDD size logging Signed-off-by: William Hankins <william@sundae.fi>
|
Very happy with this :-) Interested to know if there was a reason you wrote the test in TS - ease of CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validation tool to compare the Acropolis-generated SPDD with the epoch stakes reported by DB Sync.
It provides a trusted reference for verifying our active-stake snapshot and helps identify discrepancies between the Acropolis state and the real on-chain data. Done as part of #234.
Bugs found during validation:
Fix: Pay MIRs to reward account at the start of the epoch instead of delaying until reward calculation.
Fix: Filter based on active pool set.
Note: I was unable to find the fix but this may be an early Shelley era bug. In epoch 209 we have 3 pools missing 500 ADA of active stake due to deregistration and subsequent reregistration of their pools.
Example output
(The 42 pool mismatch is due to MIRs not being included.)
Other changes:
spdd_retation_epochsconfig option inomnibus.tomlto always require an integer, removing the separatestore-spdd-historyflag (Set to 0 by default which is equivalent tostore-spdd-history=false)./spdd?epoch={n}REST handler inspdd_state, which is used by the validator.StakeAddressMapmethods.